Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitwise transaction without correct format #11

Closed
Sha-yol opened this issue Sep 14, 2024 · 2 comments
Closed

Splitwise transaction without correct format #11

Sha-yol opened this issue Sep 14, 2024 · 2 comments

Comments

@Sha-yol
Copy link
Contributor

Sha-yol commented Sep 14, 2024

Right now, incorrectly formatted SW expenses get passed.
If we make the change suggested in #9 , we would want to start tracking SW expenses made by other people, who might not want to bother with adding the specifier string.

I suggest adding an option, controlled by the env file, determining the default behavior in case of incorrect format, something like ADD_MISFORMATTED_EXPENSES. If false, behave as right now. If true, add those expenses to FF, using the defaults defined for category, source, target, etc.
In addition, add a FIXME tag or something similar for manual fixing on FF.
This would require resolving #4.

@adyanth
Copy link
Owner

adyanth commented Sep 14, 2024

Could you expand on what the misformatted expenses getting passed are?

Also, other people adding comments for your FF instance does not sound right. It would have to be you adding a comment on an expense someone else created. Unless after you add a comment, they try to update the notes with the firefly string, this should not be a problem afaik.

@Sha-yol
Copy link
Contributor Author

Sha-yol commented Sep 30, 2024

I meant expenses added without the Firefly/... comment string to identify it for the syncher. I saw what you wrote on #9 - it's definitely simpler for now to add the comment myself if someone else added the expense.
Note the obvious failure mode - if FF and this syncher get very popular, it might be the the case that I added an expense with my friend, and both of us want to add it to our FF instance :) but we'll figure something out if it becomes a problem.

@Sha-yol Sha-yol closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants