You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
We escape =?& already, but we should also escape {}|\^~[]`" because those characters make it harder for users to paste our URLs into chat/Markdown/etc (the list is as per https://tools.ietf.org/html/rfc3986#section-2.4).
Those characters have to be escaped everywhere a regex is rendered in a URL – i.e. ?query, ?filePath and ?filter.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We escape
=?&
already, but we should also escape{}|\^~[]`"
because those characters make it harder for users to paste our URLs into chat/Markdown/etc (the list is as per https://tools.ietf.org/html/rfc3986#section-2.4).Those characters have to be escaped everywhere a regex is rendered in a URL – i.e.
?query
,?filePath
and?filter
.The text was updated successfully, but these errors were encountered: