Skip to content

Latest commit

 

History

History
48 lines (39 loc) · 1.75 KB

CONTRIBUTING.md

File metadata and controls

48 lines (39 loc) · 1.75 KB

How to contribute

Bug reports in the issue tracker and pull requests are welcome.

Pull request

  1. Fork the repository at github.
  2. Clone your fork.
$ git clone https://github.com/YOUR_GIT_USERNAME/pymysensors.git
$ cd pymysensors
  1. Add the main repository as upstream.
$ git remote add upstream https://github.com/theolind/pymysensors.git
  1. Fetch dev branch from upstream and checkout to a local branch.
$ git fetch upstream dev
$ git checkout dev
  1. Create a topic branch based off dev branch.
$ git checkout -b cool_new_feature dev
  1. Make your changes in the new topic branch. New features should preferably be accompanied with new tests. PEP8 and PEP257 style should be followed. We use pylint and flake8 as code linters.
  2. Test with tox and make sure existing tests don't fail. Linting will also be checked when tox is run.
$ pip3 install tox
$ tox
  1. Add and commit your work and describe the additions and or changes in the commit message. Use an editor for the commit message, not the command line. Try to keep the header of the commit message within 50 characters and the body within 72 characters per line. A blank line should separate the header from the body of the commit message. Markdown is cool.
$ git add -A
$ git commit
  1. Push you local changes to your fork.
$ git push origin HEAD
  1. Create a pull request at github to the main pymysensors repository and target the dev branch with your changes. The master branch should only be targeted when a new version of pymysensors is ready. Changes in the dev branch is then merged with the master branch.
  2. Watch Travis builds turn green ✅, and get the 👍 in the code review.