-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oculus-touch-controls & hand-tracking-controls combo: The controller does not appear in combination. (1.5 and master works) #5584
Comments
If it works on master then it will be fixed in the next version. Have you tried the very latest master build? Thanks |
Yes, it works in the master, i have tried! |
Cool. Thanks for taking the time to report |
That's peculiar. I can reproduce the issue with the emulator, but I see it happening on master as well. Just tested it on a Quest 3 and I do see the reported issue even with master. Here's a live reproduction: https://glitch.com/edit/#!/jagged-three-cinema?path=index.html%3A3%3A138 Doing a git bisect leads to the following (dbdb9da):
Which explains the observed behaviour. The |
Some info from Discord:
|
A-Frame is now only looking into |
With trackedSource now containing the "secondary" input I would not expect multimodal input to work in any A-Frame version. I'm assuming Meta Browser. So not sure how 1.5 or master might be working |
Probably best to create a separate issue for
I'm not sure A-Frame should adjust. Reading the spec, the user agent determines which input sources are "active" and which are (only) "tracked". In theory the active input sources could already be multi-modal, but IIRC the Meta Browser only ever briefly exposed it as such and reverted this behaviour. Tracked sources are intended to provide pose data. We should consider what the best way to surface them is, without overcomplicating things for the user. Simply treating them as if they were "active" input sources is going to cause issue. For example there could be 4 sources (hands + controllers) and the custom pinch detection logic of A-Frame would emit pinch events from the tracked hands even if the controllers are deemed the only "active" input sources by the browser. |
Description:
Just as information, in case someone wants to use this with A-Frame 1.6, it works in A-Frame 1.5!
master does not work, was a mistake, I have now edited it.
When using oculus-touch-controls and hand-tracking-controls together, the controller does not appear. It only shows up when the hands and controller are switched during the session, at which point the controller appears and functions. If the controllers are put down during the session and the hands are used for hand tracking, then when the controllers are picked up again, the controller appears and works. It just doesn’t show up at the start with the controllers.
<a-entity oculus-touch-controls="hand: left" hand-tracking-controls="hand: left"></a-entity>
The text was updated successfully, but these errors were encountered: