gitsources: improve error reporting

[sgotti]

Currently when an errors occurs inside a gitsource method it's considered as a generic error and reported to api clients as an internal server error masking the error message. So some agola cli commands will just report a generic "internal server error" instead of the real error when the user provides some wrong options that are passed to the git sources.

We can do two things:

• Handle all the gitsources errors as generic errors that can be reported to the api users
• Improve the gitsources api to report different kind of errors (internal, user etc...) like already done by the actions errors.

[alessandro-sorint]

@sgotti I don't understand this card because I see the gitsources api just returns custom errors. I don't see git generic errors when I call gateway api client, what we have to do?

[sgotti]

@alessandro-sorint Take a look at the methods calling a gitsource. You'll see that the gitsource error is wrapped in a generic error that will become a 500 when called by the api. Anyway this is something that requires thorough reasoning before implementing something. I'll come back to this later if/when needed.

[alessandro-sorint]

@alessandro-sorint Take a look at the methods calling a gitsource. You'll see that the gitsource error is wrapped in a generic error that will become a 500 when called by the api. Anyway this is something that requires thorough reasoning before implementing something. I'll come back to this later if/when needed.

I think we can use the ErrInternal in util package or create and use a new ErrGitea and user it?
With ErrInternal or ErrGitea the api will report the gitea error message and with 500 http code(we can use a different code?)

[sgotti]

@alessandro-sorint This isn't related to the implementation but to understand how to convert gitsources errors to the errors reported to the user. Which remote sources errors should be reported to the user? Which not? How to map the different gitsource types errors (gitea, github, gitlab) to a set of agola errors? etc...

I think we can use the ErrInternal

ErrInternal is the same as returning a generic error.

[alessandro-sorint]

@alessandro-sorint This isn't related to the implementation but to understand how to convert gitsources errors to the errors reported to the user. Which remote sources errors should be reported to the user? Which not? How to map the different gitsource types errors (gitea, github, gitlab) to a set of agola errors? etc...

I think we can use the ErrInternal

ErrInternal is the same as returning a generic error.

@sgotti for the types of errors I guess maybe you mean the various http 400,500 etc. how to map them
I've seen which of these are returned by gitsources gitea/github/gitlab api: 403, 404, 409, 422, 500, 503
Of these I think it is worth making the user see the error 403 (unauthorized), 404 (not found), 422 (Unprocessable Entity) and 503 (service unavailable).
I need gitea sdk updated bacause at the moment it not returns the http status code.