Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some duplication in asset retrieval code #32

Open
mcgibbon opened this issue Nov 21, 2019 · 1 comment
Open

Remove some duplication in asset retrieval code #32

mcgibbon opened this issue Nov 21, 2019 · 1 comment

Comments

@mcgibbon
Copy link
Collaborator

Some of the code introduced by #27 could be reduced by writing generic functions that can be re-used for the different types of run data (e.g. orographic, input, forcing...). This would improve maintainability and make it easier to generalize the code down the line for different models.

@oliverwm1
Copy link

Ditto for the get_directory and get_table_filename functions in _datastore.py and _tables.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants