From 061bb335e87690d74a55430a4fc2f0273001e12e Mon Sep 17 00:00:00 2001 From: Ernst Roell Date: Mon, 10 Jun 2024 16:54:22 +0200 Subject: [PATCH 1/6] Test release notes --- .github/workflows/dataset_release.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/dataset_release.yaml b/.github/workflows/dataset_release.yaml index 55c245c..74c848e 100644 --- a/.github/workflows/dataset_release.yaml +++ b/.github/workflows/dataset_release.yaml @@ -29,6 +29,7 @@ jobs: if: startsWith(github.ref, 'refs/tags/') with: draft: true + body_path: CHANGELOG.md generate_release_notes: true make_latest: true files: | From 0ee316a2e628fb34a4836a1a4b1bff1021cd57d6 Mon Sep 17 00:00:00 2001 From: Ernst Roell Date: Mon, 10 Jun 2024 17:02:58 +0200 Subject: [PATCH 2/6] test --- .github/workflows/dataset_release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dataset_release.yaml b/.github/workflows/dataset_release.yaml index 74c848e..7f28542 100644 --- a/.github/workflows/dataset_release.yaml +++ b/.github/workflows/dataset_release.yaml @@ -26,7 +26,7 @@ jobs: - name: Release uses: softprops/action-gh-release@v2 - if: startsWith(github.ref, 'refs/tags/') + # if: startsWith(github.ref, 'refs/tags/') with: draft: true body_path: CHANGELOG.md From 65f4da84caf977c26bb3a3ef8c323de22625487a Mon Sep 17 00:00:00 2001 From: Ernst Roell Date: Mon, 10 Jun 2024 17:36:39 +0200 Subject: [PATCH 3/6] Revert pylint --- .github/workflows/pylint.yaml | 19 ------------------- README.md | 2 +- 2 files changed, 1 insertion(+), 20 deletions(-) delete mode 100644 .github/workflows/pylint.yaml diff --git a/.github/workflows/pylint.yaml b/.github/workflows/pylint.yaml deleted file mode 100644 index 60905cf..0000000 --- a/.github/workflows/pylint.yaml +++ /dev/null @@ -1,19 +0,0 @@ -name: Python Linting -on: - push: - pull_request: - workflow_dispatch: -jobs: - build: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v5 - with: - python-version: '3.10.11' - cache: 'pip' # caching pip dependencies - - run: pip install pylint - - name: flake8 Lint - uses: py-actions/flake8@v2 - - name: Run Pylint - run: pylint mantra \ No newline at end of file diff --git a/README.md b/README.md index bc17784..fc52d32 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # MANTRA: Manifold Triangulations Assembly -[![Maintainability](https://api.codeclimate.com/v1/badges/82f86d7e2f0aae342055/maintainability)](https://codeclimate.com/github/aidos-lab/MANTRA/maintainability) ![GitHub contributors](https://img.shields.io/github/contributors/aidos-lab/MANTRA) ![GitHub](https://img.shields.io/github/license/aidos-lab/MANTRA) ![pylint]() +[![Maintainability](https://api.codeclimate.com/v1/badges/82f86d7e2f0aae342055/maintainability)](https://codeclimate.com/github/aidos-lab/MANTRA/maintainability) ![GitHub contributors](https://img.shields.io/github/contributors/aidos-lab/MANTRA) ![GitHub](https://img.shields.io/github/license/aidos-lab/MANTRA) ## Getting the Dataset From 81eb2cb8ec63a052582c795e60735d816ec5d7bc Mon Sep 17 00:00:00 2001 From: Daniel Bin Schmid Date: Tue, 11 Jun 2024 09:36:31 +0200 Subject: [PATCH 4/6] improvement: split url in two variables to avoid line-splitting because the line-split led to a bug. --- mantra/simplicial.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mantra/simplicial.py b/mantra/simplicial.py index f47988e..d153807 100644 --- a/mantra/simplicial.py +++ b/mantra/simplicial.py @@ -48,8 +48,9 @@ def __init__( self.manifold = manifold root += "/simplicial" self.version = version - self.url = f"https://github.com/aidos-lab/MANTRADataset/releases/\ - {self.version}/download/{self.manifold}_manifolds.json.gz" + url_prefix = "https://github.com/aidos-lab/MANTRADataset/releases/" + url_suffix = f"{self.version}/download/{self.manifold}_manifolds.json.gz" + self.url = url_prefix + url_suffix super().__init__(root, transform, pre_transform, pre_filter) self.load(self.processed_paths[0]) From 036a0e07d3e8a35abb2b3b3c0c19f7f4de36d1b8 Mon Sep 17 00:00:00 2001 From: Daniel Bin Schmid Date: Tue, 11 Jun 2024 09:43:03 +0200 Subject: [PATCH 5/6] autoformatting with black --- mantra/simplicial.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mantra/simplicial.py b/mantra/simplicial.py index d153807..092e4fa 100644 --- a/mantra/simplicial.py +++ b/mantra/simplicial.py @@ -49,7 +49,9 @@ def __init__( root += "/simplicial" self.version = version url_prefix = "https://github.com/aidos-lab/MANTRADataset/releases/" - url_suffix = f"{self.version}/download/{self.manifold}_manifolds.json.gz" + url_suffix = ( + f"{self.version}/download/{self.manifold}_manifolds.json.gz" + ) self.url = url_prefix + url_suffix super().__init__(root, transform, pre_transform, pre_filter) self.load(self.processed_paths[0]) From b81dc4ef8dfb40e97cd6270c5b6bd5f5bf39d844 Mon Sep 17 00:00:00 2001 From: Daniel Bin Schmid Date: Tue, 11 Jun 2024 09:51:09 +0200 Subject: [PATCH 6/6] using # noqa instead of splitting long line into two --- mantra/simplicial.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mantra/simplicial.py b/mantra/simplicial.py index 092e4fa..44bcb5e 100644 --- a/mantra/simplicial.py +++ b/mantra/simplicial.py @@ -48,11 +48,7 @@ def __init__( self.manifold = manifold root += "/simplicial" self.version = version - url_prefix = "https://github.com/aidos-lab/MANTRADataset/releases/" - url_suffix = ( - f"{self.version}/download/{self.manifold}_manifolds.json.gz" - ) - self.url = url_prefix + url_suffix + self.url = f"https://github.com/aidos-lab/MANTRADataset/releases/{self.version}/download/{self.manifold}_manifolds.json.gz" # noqa super().__init__(root, transform, pre_transform, pre_filter) self.load(self.processed_paths[0])