-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing docs for timeout parameter in WebSocketResponse.__init__() #9497
Open
lenard-mosys
wants to merge
6
commits into
aio-libs:master
Choose a base branch
from
lenard-mosys:websocketresponse_close_timeout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add missing docs for timeout parameter in WebSocketResponse.__init__() #9497
lenard-mosys
wants to merge
6
commits into
aio-libs:master
from
lenard-mosys:websocketresponse_close_timeout
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9497 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 105 105
Lines 35093 35097 +4
Branches 4179 4179
=======================================
+ Hits 34600 34604 +4
Misses 329 329
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
webknjaz
reviewed
Oct 17, 2024
Dreamsorcerer
added
backport-3.10
Trigger automatic backporting to the 3.10 release branch by Patchback robot
backport-3.11
Trigger automatic backporting to the 3.11 release branch by Patchback robot
bot:chronographer:skip
This PR does not need to include a change note
labels
Oct 17, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-3.10
Trigger automatic backporting to the 3.10 release branch by Patchback robot
backport-3.11
Trigger automatic backporting to the 3.11 release branch by Patchback robot
bot:chronographer:skip
This PR does not need to include a change note
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds missing documentation.
Are there changes in behavior for the user?
No.
Is it a substantial burden for the maintainers to support this?
No
Related issue number
This was easier than opening an issue.
Checklist
Unit tests for the changes existIf you provide code modification, please add yourself toCONTRIBUTORS.txt
CHANGES/
folder