Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add bitcode support #84

Open
mgrebenets opened this issue Apr 15, 2019 · 0 comments
Open

[Feature] Add bitcode support #84

mgrebenets opened this issue Apr 15, 2019 · 0 comments

Comments

@mgrebenets
Copy link
Contributor

mgrebenets commented Apr 15, 2019

It would be great to have bitcode support added to the sample.

From the research I had earlier, it's the -fembed-bitcode flag that has to be added to compiler and linker flags.
I tried it before, but I think I may have missed couple options, like Swift compiler flags or maybe even ldflags (?).

Ideally, the bitcode option should be an on/off option in .buckconfig, which could then be controlled from command line.

The reason: to be able to build different projects in monorepo with and without bitcode.
We actually have a setup, where one app can enable bitcode but another one cannot (due to 3-rd party pre-built binary missing bitcode).

I think building with/without bitcode, would mean that different cache directory should be used.

Or, what I tried as well, everything that can be built with bitcode, should be built with bitcode, but then when, say a library, is used in an app that doesn't support bitcode, the bitcode can be stripped out of the binary. That, or each library can generate two artifacts, one with bitcode, one stripped, so then the apps/target products can pick the one fitting their needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant