Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blocked on CI upgrade] Test that app installs to simulator via CLI in CI #99

Closed
wants to merge 3 commits into from
Closed

[Blocked on CI upgrade] Test that app installs to simulator via CLI in CI #99

wants to merge 3 commits into from

Conversation

bachand
Copy link
Collaborator

@bachand bachand commented Apr 28, 2019 •
edited
Loading

Fixes #93. We cannot remove "Built and ran with Buck CLI (make debug)" from the PR template until #94 is fixed as well. And we can't do that until we get the app to actually run via the CLI again 😬

I verified that when make debug times out it fails with a non-zero exit code.

@bachand bachand requested a review from dfed April 28, 2019 05:37
@dfed
Copy link
Collaborator

dfed commented Apr 28, 2019

Almost there! Build failure is:

BUILD FAILED: Cannot install //App:ExampleApp#dwarf-and-dsym,no-include-frameworks (no appropriate simulator found)

We might want to change our Makefile so that debug that doesn’t specify a specific simulator. Alternatively, we may be able to get away with an iPhone X, SE or another device that is known to Xcode 9 (currently we’re selecting an XS).

@bachand or @qyang-nj: do you remember why we are specifying a specific sim in our Makefile?

@bachand
Copy link
Collaborator Author

bachand commented May 2, 2019 •
edited
Loading

I don't know why we added this. I think it's been around awhile. Probably added it so we didn't end up with something random.

I tried iPhone X. No luck.

BUILD FAILED: Cannot install //App:ExampleApp#dwarf-and-dsym,no-include-frameworks (could not start simulator iPhone X within 20000 ms)

@qyang-nj
Copy link
Collaborator

qyang-nj commented May 2, 2019

If we don't give a name, it's iPhone 5s by default. I guess we wanted a high-resolution simulator.

@qyang-nj
Copy link
Collaborator

qyang-nj commented May 2, 2019

Probably we need Phone: iPhone X for Xcode 9. That's why we added there. Just a guess. I don't have Xcode 9 any more.

@bachand
Copy link
Collaborator Author

bachand commented May 2, 2019

Ok let’s put this on ice until we upgrade CI

@bachand bachand changed the title Test that app installs to simulator via CLI in CI [Blocked in Xcode 10] Test that app installs to simulator via CLI in CI May 2, 2019
@bachand bachand changed the title [Blocked in Xcode 10] Test that app installs to simulator via CLI in CI [Blocked on CI upgrade] Test that app installs to simulator via CLI in CI May 2, 2019
@bachand bachand closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfed dfed Awaiting requested review from dfed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI to verify that the app successfully installs via Buck CLI (make debug)
3 participants
@bachand @dfed @qyang-nj