-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module build failed: SyntaxError: Unexpected token (1:1) #38
Comments
I can confirm this bug. |
Can either of you compare it to v0.5.1? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@catamphetamine @DiederikvandenB can either of you confirm that you are transpiling modules, since otherwise import statements won’t work in node? |
Can confirm it happen in v1.0.0 |
@lxcid same question - are you transpiling modules? whats your babel config? |
@ljharb here is mine:
package.json
{
"name": "tcs",
"version": "0.14.2",
"description": "Turtle Control Software",
"main": "index.js",
"scripts": {
"watch": "parcel watch ./client/src/index.html --out-dir ./client/dist --public-url ./ --no-hmr",
"serve": "parcel serve ./client/src/index.html --out-dir ./client/dist --public-url / -p 3000",
"build": "parcel build ./client/src/index.html --out-dir ./client/dist --public-url ./",
"lint": "eslint --ext .js client/src/"
},
"repository": "git+https://github.com/TurtleRover/tcs.git",
"keywords": [],
"author": "",
"license": "MIT",
"devDependencies": {
"@babel/core": "^7.2.2",
"@babel/plugin-transform-react-jsx": "^7.2.0",
"@babel/plugin-transform-runtime": "^7.2.0",
"@babel/preset-env": "^7.2.0",
"@babel/template": "^7.2.2",
"eslint": "^5.10.0",
"eslint-config-airbnb": "^17.1.0",
"eslint-config-airbnb-base": "^13.1.0",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-jsx-a11y": "^6.1.2",
"eslint-plugin-react": "^7.11.1",
"node-sass": "^4.11.0",
"parcel-bundler": "1.11.0",
"babel-plugin-inline-react-svg": "^1.0.1"
},
"dependencies": {
"@hyperapp/logger": "^0.5.0",
"hyperapp": "^1.2.9",
"keyboardjs": "^2.5.1",
"lodash": "^4.17.11",
"nipplejs": "^0.7.3",
"socket.io-client": "^2.2.0"
}
} |
@stsdc The transform-react-jsx transform is the problem; you'll need to change your config ordering so that runs after inline-react-svg, I think. Specifically, this transform is for react, so if you're using a different jsx project, it's not expected to work in every configuration. |
@himadrinath i wouldn’t recommend transpiling code in node_modules. |
@ljharb - I can confirm I experience a similar issue. And a very simple .babelrc:
When setting |
In that case this might be related to #49. |
Why do you need to set svgo to false ? I had the samee issue theen following the instructions from the babel-plugin-inline-react-svg documentation solved it :
|
I can confirm this issue in babel.config.js: module.exports = {
presets: [
'@babel/preset-env',
'@babel/preset-react'
],
sourceType: 'unambiguous',
plugins: [
[
'inline-react-svg',
{
svgo: false
}
]
]
}; Test.svg: <?xml version="1.0" encoding="utf-8"?>
<!--Generator: Adobe Illustrator 20.1.0, SVG Export Plug-In . SVG Version: 6.00 Build 0)-->
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" viewBox="0 0 18 30" style="enable-background:new 0 0 18 30" xml:space="preserve">
<path d="M0,15l15,15l3-3L6,15L18,3l-3-3L0,15z" style="fill:#FFFFFF"/>
</svg> index.js import React from 'react';
import Sprite from './sprite.svg';
const Component = () => (
<Sprite />
);
export default Component; shell output: > babel --config-file ./babel.config.js index.js --out-file dist.js
SyntaxError: /Users/j.cousins/Dev/tests/babel-inline-react-svg-test/index.js: Unexpected token (1:1) |
Anyone solved this issue? SyntaxError: Unexpected token (1:1) I got the same issue as @jcousins-ynap |
Hi, not sure if it is the same problem you all have but I came across this before when adding some new SVG to my project and solved it by removing the first line from my SVG files ie. the |
If I specify plugin config in
.babelrc
it throws the error.If I then use just
"inline-react-svg"
in.babelrc
then it doesn't throw the error.But in the default mode it discards half of attributes like
stroke-width="2.5"
.The text was updated successfully, but these errors were encountered: