Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version numbers #7

Open
jaythomas opened this issue Mar 4, 2017 · 2 comments
Open

Version numbers #7

jaythomas opened this issue Mar 4, 2017 · 2 comments

Comments

@jaythomas
Copy link

It would be great if the utilities had version numbers, so when checking to see if I have the latest version of one of them I can compare the version numbers instead of diffing. A rockspec would be ideal, but a simple comment at the top or table property would be better than nothing. If you want a pull request let me know. Thanks!

@airstruck
Copy link
Owner

Aren't rockspecs limited to package-level versioning? I think a separate rockspec for each module is overkill, and it seems weird for all modules to share a version number as a package. It's been a few years since I've bothered with packaging rocks, so I may be missing something. If you want rocks and want to make a pull request, I'll definitely take a look.

Many of the modules are functions and would need to be converted to callable tables for table properties to work.

A comment at the top certainly isn't too much to ask; we can do that if the rockspec thing doesn't pan out.

@jaythomas
Copy link
Author

If you put version numbers in the file headers as a code comment that would be sufficient for my needs.

I do agree that one luarock and one version over all the modules wouldn't be ideal. If a user only wants one or two modules they would need to install them all.

Likewise, if each module has its own luarock then it appears you will also need to create tarballs to publish each module and maintenance would become a hassle. I can't find anything in the documentation that specifically mentions the ability to package individual sub-directories from a single github repository. Basically the modules would need to be broken out into separate directories to avoid git tag conflicts and other headaches that clash with the design of luarocks and the rockspec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants