Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment markers set in first ~0.5 seconds of the video should be recorded as exactly 0 #465

Open
jack-webb opened this issue Sep 9, 2020 · 4 comments

Comments

@jack-webb
Copy link

jack-webb commented Sep 9, 2020

I've noticed users submitting segments for the beginnings of videos, but not setting the marker to exactly the start, rather, a few milliseconds away. This ends up in a pretty jarring jump after half a word of a sponsor slot, for example. It's not a super widespread problem, but I've seen it enough to warrant a report, and I don't think it'd be much work to implement.

Of course, this all applies to the ends of videos too, but this is less common owing to the definite end screen.

If a marker is placed within half a second or so of the start of the video, the marker should be treated as if it were set at the start of the video. I don't think any meaningful content could appear in a half second segment at the start of the video, so it seems like
a good way of weeding out any slightly off submissions.

Finally, thanks for building and hosting this project. It's made viewing so much nicer.

Edit: I looked at the server, and maybe this is better on the server side, particularly to handle users who don't have an updated extension. Not gonna open a duplicate issue, but might as well mention it. Editing it on the server to modify existing client behaviour is probably not a good practice in hindsight..

@jack-webb jack-webb changed the title Segment markers set in first few milliseconds of the video should be recorded as exactly 0 Segment markers set in first ~0.5 seconds of the video should be recorded as exactly 0 Sep 12, 2020
@eldorel
Copy link

eldorel commented Nov 16, 2020

I'm going to add an example to this as well.
https://www.youtube.com/watch?v=C67C5vb3OYI

The linked video had a segment that missed the first 150ms, and the initial sound of the intro is VERY loud.

I created a new segment that doesn't have the issue, but I still had to manually edit the segment to remove the 0.8s blip at the start even though I stopped the video and jumped back three times to try and hit the very start.

I honestly can't think of any reason why a segment should ever be allowed to cut that close the the start or end of a video.

@dmitrybatyuk
Copy link

Example: https://www.youtube.com/watch?v=Mcx5lZAJhAk

Feature request: "Edit like" option - like but ask to add or remove some milliseconds on start and end

Maybe it's good to make option "ok, I liked this filter but maybe it's better to drop additional 200-500-1000 ms before start". If there are ~5 of such "edit likes" - give both options to users. If first option gets new "edit likes" and second only clean likes - modify filter to second option.

@jack-webb
Copy link
Author

Feature request: "Edit like" option - like but ask to add or remove some milliseconds on start and end

This is covered as part of https://sb.ltn.fi/ - you can vote on segments there. Most videos that have the near-miss segments relevant here have corrected segments on sb.ltn.fi, just that they are not the highest rated, so aren't shown.

Because this is a different feature request, it would be good if you opened an issue, so we can follow it separately.

@mirror176
Copy link

Instead of just an autocorrect feature (which I prefer be an option if it is brought in) we have a few things helping right now:

  • Sponsorblock does have the 'start' button to alter a marking to be at the beginning of a video or with more clicks the time can be manually edited by putting in a 0 if that was the intent.
  • Previewing a segment before submission should have shown the user the error that was made.
  • At least on Firefox if you don't have autoplay enabled then starting a segment before you hit play or seek should also start it at the 0 mark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants