-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment markers set in first ~0.5 seconds of the video should be recorded as exactly 0 #465
Comments
I'm going to add an example to this as well. The linked video had a segment that missed the first 150ms, and the initial sound of the intro is VERY loud. I created a new segment that doesn't have the issue, but I still had to manually edit the segment to remove the 0.8s blip at the start even though I stopped the video and jumped back three times to try and hit the very start. I honestly can't think of any reason why a segment should ever be allowed to cut that close the the start or end of a video. |
Example: https://www.youtube.com/watch?v=Mcx5lZAJhAk Feature request: "Edit like" option - like but ask to add or remove some milliseconds on start and end Maybe it's good to make option "ok, I liked this filter but maybe it's better to drop additional 200-500-1000 ms before start". If there are ~5 of such "edit likes" - give both options to users. If first option gets new "edit likes" and second only clean likes - modify filter to second option. |
This is covered as part of https://sb.ltn.fi/ - you can vote on segments there. Most videos that have the near-miss segments relevant here have corrected segments on sb.ltn.fi, just that they are not the highest rated, so aren't shown. Because this is a different feature request, it would be good if you opened an issue, so we can follow it separately. |
Instead of just an autocorrect feature (which I prefer be an option if it is brought in) we have a few things helping right now:
|
I've noticed users submitting segments for the beginnings of videos, but not setting the marker to exactly the start, rather, a few milliseconds away. This ends up in a pretty jarring jump after half a word of a sponsor slot, for example. It's not a super widespread problem, but I've seen it enough to warrant a report, and I don't think it'd be much work to implement.
Of course, this all applies to the ends of videos too, but this is less common owing to the definite end screen.
If a marker is placed within half a second or so of the start of the video, the marker should be treated as if it were set at the start of the video. I don't think any meaningful content could appear in a half second segment at the start of the video, so it seems like
a good way of weeding out any slightly off submissions.
Finally, thanks for building and hosting this project. It's made viewing so much nicer.
Edit: I looked at the server, and maybe this is better on the server side, particularly to handle users who don't have an updated extension. Not gonna open a duplicate issue, but might as well mention it.Editing it on the server to modify existing client behaviour is probably not a good practice in hindsight..The text was updated successfully, but these errors were encountered: