Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification emails: duplicated follower emails #428

Closed
jeherve opened this issue Jan 15, 2025 · 5 comments · Fixed by #434
Closed

Notification emails: duplicated follower emails #428

jeherve opened this issue Jan 15, 2025 · 5 comments · Fixed by #434

Comments

@jeherve
Copy link
Contributor

jeherve commented Jan 15, 2025

Email notifications for new followers were recently added to the ActivityPub plugin:
Automattic/wordpress-activitypub#1068

This is nice, but in practice that means that we now receive 2 emails for each new follower:

image

It would be nice if the plugins could play well with each other, and only send out a single email.

cc @pfefferle

@akirk
Copy link
Owner

akirk commented Jan 15, 2025

Thanks for highlighting this. I suggest to remove it from the Friends plugin now that ActivityPub has it.

@akirk
Copy link
Owner

akirk commented Jan 15, 2025

Although, I have to say that the Friends mail has more useful info, like a picture and the user description. Maybe I can augment the ActivityPub data? Shall we add a filter here, @pfefferle?

@jeherve
Copy link
Contributor Author

jeherve commented Jan 15, 2025

If there is a way to get that additional data in the ActivityPub plugin, that would be nice indeed! Would there be a way to get that info for all ActivityPub users, even when they don't use the Friends plugin?

@akirk
Copy link
Owner

akirk commented Jan 15, 2025

FWIW you can already today disable the e-mails in the Friends Notification settings (wp-admin/admin.php?page=friends-notification-manager):

Screenshot 2025-01-15 at 16 18 12

@akirk
Copy link
Owner

akirk commented Jan 16, 2025

I started working on this in Automattic/wordpress-activitypub#1172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants