Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swipe ssl-config usages from the codebase #897

Closed
ignasi35 opened this issue May 4, 2021 · 2 comments
Closed

Swipe ssl-config usages from the codebase #897

ignasi35 opened this issue May 4, 2021 · 2 comments
Assignees
@raboof
Milestone
1.1.0

Comments

@ignasi35
Copy link
Contributor

ignasi35 commented May 4, 2021

In #893 we removed the usages of AkkaSslConfig as that is deprecate in Akka HTTP 10.2.0. There may be some left-overs in form of dependencies or HOCON config snippets still referring to the (now unused) ssl-config. These left-overs should be removed.
@ignasi35 ignasi35 added this to the 1.1.0 milestone May 4, 2021
@raboof
Copy link
Contributor

raboof commented May 4, 2021

A quick grep suggests only ./management/src/test/scala/akka/management/AkkaManagementHttpEndpointSpec.scala - did you see other occurances?

@raboof raboof self-assigned this May 4, 2021
@raboof raboof mentioned this issue May 4, 2021
Merged
@raboof raboof closed this as completed May 7, 2021
@raboof
Copy link
Contributor

raboof commented May 7, 2021

(removed the case I found, let's take care of any other cases after the release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raboof raboof

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@raboof @ignasi35