Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TransactionalProducer implementation once Confluent driver support this #85

Open
IgorFedchenko opened this issue Oct 30, 2019 · 5 comments · May be fixed by #196
Open

Fix TransactionalProducer implementation once Confluent driver support this #85

IgorFedchenko opened this issue Oct 30, 2019 · 5 comments · May be fixed by #196

Comments

@IgorFedchenko
Copy link
Contributor

There are couple of TODO labels in TransactionalProducerStage.cs file (in TransactionalProducerStageLogic class implementation). This is due to lack of transactional operations support in Confluent driver's producer implementation.

This also requires some librdkafka update. The issue to track is confluentinc/confluent-kafka-dotnet#1091.

Once this will be ready, implementation should work (there is a test at TransactionalIntegrationTests.cs that is skipped right now).
This was referenced Oct 30, 2019
Merged
Open
@IgorFedchenko IgorFedchenko mentioned this issue Dec 17, 2019
Closed
@IgorFedchenko
Copy link
Contributor Author

Looks like they have published update which includes transaction support: https://www.nuget.org/packages/Confluent.Kafka/1.4.0

So now we can implement missing transactional stages.

@IgorFedchenko IgorFedchenko linked a pull request Mar 25, 2021 that will close this issue
Open
@chris-sung
Copy link

ah, this is a long waiting feature that I'm waiting to be implemented

@IgorFedchenko
Copy link
Contributor Author

@chris-sung Yeah, the problem is that _producer.InitTransactions call to Confluent driver is blocking for some reason, and I can't make my PR passing tests. And I ran out of time, not able to fix it now... If you will have time and willing to check it out or fork my branch and play with this, you are wellcome :)

Otherwise it may take a long time to have this working...

@rafalpiotrowski
Copy link

Hi, Is this resolved now? or still pending?

@IgorFedchenko
Copy link
Contributor Author

Hey, nope, this is not resolved - there is a PR (#196) which was never finished (see comments above). Probably it will work now with latest driver versions, not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make TransactionalProducer implementation working IgorFedchenko/Akka.Streams.Kafka
3 participants
@rafalpiotrowski @chris-sung @IgorFedchenko