Support secure schema access #1369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
reviewed
Jan 15, 2025
jfallows
requested changes
Jan 22, 2025
...s/io/aklivity/zilla/specs/catalog/schema/registry/config/resolve/schema/id/secure/zilla.yaml
Outdated
Show resolved
Hide resolved
specs/engine.spec/src/main/scripts/io/aklivity/zilla/specs/engine/schema/engine.schema.json
Show resolved
Hide resolved
...pts/io/aklivity/zilla/specs/catalog/schema/registry/schema/schema.registry.schema.patch.json
Outdated
Show resolved
Hide resolved
.../runtime/catalog/schema/registry/internal/config/SchemaRegistryOptionsConfigAdapterTest.java
Outdated
Show resolved
Hide resolved
...klivity/zilla/runtime/catalog/schema/registry/internal/SchemaRegistryCatalogHandlerTest.java
Outdated
Show resolved
Hide resolved
...ity/zilla/runtime/catalog/schema/registry/internal/handler/SchemaRegistryCatalogHandler.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/catalog/schema/registry/internal/SchemaRegistryCatalogContext.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/catalog/schema/registry/internal/SchemaRegistryCatalogContext.java
Outdated
Show resolved
Hide resolved
...io/aklivity/zilla/runtime/catalog/schema/registry/internal/SchemaRegistryCatalogContext.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Jan 24, 2025
| @@ -97,7 +98,7 @@ public SchemaRegistryCatalogHandler( | |||
| VaultHandler vault = supplyVault.apply(catalog.vaultId); | |||
|
|
|||
| HttpClient client; | |||
| if (vault != null) | |||
| if (this.baseUrl.regionMatches(true, 0, HTTPS, 0, 5)) | |||
There was a problem hiding this comment.
Suggested change
| if (this.baseUrl.regionMatches(true, 0, HTTPS, 0, 5)) | |
| if (this.baseUrl.startsWith("https://")) |
FYI - we don't tolerate case-insensitive https scheme anywhere else.
...c/test/java/io/aklivity/zilla/runtime/catalog/schema/registry/internal/SchemaRegistryIT.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/aklivity/zilla/runtime/catalog/schema/registry/internal/SchemaRegistryIT.java
Outdated
Show resolved
Hide resolved
Comment on lines
131
to
137
| "then": | ||
| { | ||
| "properties": | ||
| { | ||
| "tls": true | ||
| } | ||
| }, |
There was a problem hiding this comment.
Does this still validate the contents of tis properly when https url is present?
...ry.spec/src/test/java/io/aklivity/zilla/specs/catalog/schema/registry/config/SchemaTest.java
Outdated
Show resolved
Hide resolved
jfallows
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1195