Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give possibility to deploy/redeploy the same versions #3302

Open
3 tasks done
akolacz opened this issue Jan 17, 2025 · 3 comments
Open
3 tasks done

Give possibility to deploy/redeploy the same versions #3302

akolacz opened this issue Jan 17, 2025 · 3 comments

Comments

@akolacz
Copy link
Contributor

akolacz commented Jan 17, 2025

Checklist

  • I've searched the issue queue to verify this is not a duplicate feature request.
  • I've pasted the output of kargo version, if applicable.
  • I've pasted logs, if applicable.

Proposed Feature

We want to give the possibility to deploy/redeploy the same version through Kargo

Motivation

When we have our deployment/promotion through Kargo. For example the deployment was stuck/error on an pod/job and we fixed it directly on ArgoCD to successfully deployed the new versions. On Kargo the status of the promotion is in error we can't today redeploy the same versions through Kargo because we have the following error (that makes sense).

failed to run step "git-open-pr": error creating pull request: POST https://api.github.com/repos/my-company/my-repo/pulls: 422 Validation Failed [{Resource:PullRequest Field: Code:custom Message:No commits between main and kargo/my-repo/dev/promotion}]

with the following promotion steps:

Image

But I know before the promotions steps was added, previously we can redeploy the same versions just to say to Kargo to update the status of the promotion to green/succeeded.
Because right now the only way to put back to succeeded on Kargo is to rollback on the previous versions and redeploy the latest one, or modify manually the versions updated by kargo into our repository to say to Kargo, it's not the same versions between what you want to push and in the code.

@jessesuen
Copy link
Member

I'm guessing this is mainly a problem for the git-open-pr step?

@krancour
Copy link
Member

This possibly ties into #3228

@hiddeco
Copy link
Contributor

hiddeco commented Jan 21, 2025

Think that in addition to #3228, you would probably find yourself wanting to introduce conditional steps as well (#3125).

I.e.

steps:
- uses: git-open-pr
  as: open-pr
  config:
    ignoreIdenticalBranches: true
- uses: git-wait-for-pr
  if: ${{ outputs['open-pr'].prNumber != 0 }} # Would cause the step to be skipped if no PR number is assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants