Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE storage account ACL bug when deployed from Azure VM #2203

Open
mattwestby opened this issue Sep 25, 2024 · 8 comments
Open

SRE storage account ACL bug when deployed from Azure VM #2203

mattwestby opened this issue Sep 25, 2024 · 8 comments
Labels
bug Problem when deploying a Data Safe Haven. hotfix An issue that should be fixed on a hotfix branch, with a point release

Comments

@mattwestby
Copy link

When deploying the SRE from an azure VM the following error is received;
image

The VM is unable to connect to the storage accounts even though there is whitelisting on the storage account because the traffic is being routed over the azure backbone instead of going over the internet. Azure does not allow whitelisting of internal ip addresses on storage accounts.

@mattwestby mattwestby added the bug Problem when deploying a Data Safe Haven. label Sep 25, 2024
@JimMadge
Copy link
Member

Possibly related to #2197 and #2184.

As with those, if this is something outside of our control (Azure traffic routing) we may want to add a note to the documentation and make sure there are other container/virtual deployment methods we can support.

@jemrobinson
Copy link
Member

  1. Does the Azure VM have a public IP address?
  2. Have you added that public IP address to the list of admin_ip_addresses?
  3. Can you confirm which IP address is being blocked by the storage account?

@mattwestby
Copy link
Author

mattwestby commented Sep 26, 2024 via email

@jemrobinson
Copy link
Member

If you add a public IP address then Azure-to-Azure requests should show as coming from this public address which can be added to your allow list.

@JimMadge JimMadge added this to the Release 5.0.1 milestone Sep 30, 2024
@JimMadge
Copy link
Member

May also need to look at the settings we have available for routing from the deployment machine if it is hosted on Azure. E.g.

Screenshot 2024-09-30 at 10 25 28

@mattwestby
Copy link
Author

mattwestby commented Sep 30, 2024 via email

@jemrobinson
Copy link
Member

Think that particular setting is only available on PaaS resources?

It's a setting on the storage account.

@JimMadge
Copy link
Member

I can't see a similar setting for NICs. It is worth trying but I'm not sure whether the problem is where the request is sent from rather than with the storage account.

In general, Azure routing (or re-routing) traffic internally is great idea for speed/efficiency but it does cause us problems here.

@JimMadge JimMadge modified the milestones: Release 5.0.1, Release 5.0.2 Oct 21, 2024
@JimMadge JimMadge added the hotfix An issue that should be fixed on a hotfix branch, with a point release label Oct 29, 2024
@JimMadge JimMadge removed this from the Release 5.0.2 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem when deploying a Data Safe Haven. hotfix An issue that should be fixed on a hotfix branch, with a point release
Projects
None yet
Development

No branches or pull requests

3 participants