Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on updating SRE configurations #2291

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Add documentation on updating SRE configurations #2291

wants to merge 8 commits into from

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Nov 13, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Adds documentation for the procedure for updating SRE configurations. This includes a direct warning that changes to the admin IP addresses must initially be made from the original IP address.

🌂 Related issues

Closes #2212

🔬 Tests

Documentation only

@craddm craddm added this to the Release 5.1.0 milestone Nov 13, 2024
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@craddm craddm marked this pull request as ready for review November 14, 2024 14:00
@craddm craddm requested a review from a team as a code owner November 14, 2024 14:00
@craddm craddm changed the base branch from develop to release-v5.0.2 November 14, 2024 14:09
@craddm craddm removed this from the Release 5.1.0 milestone Nov 14, 2024
@JimMadge JimMadge changed the base branch from release-v5.0.2 to develop November 15, 2024 09:38
@JimMadge
Copy link
Member

I've changed the target to develop. I don't think we should make hotfixes from docs-only changes.

JimMadge
JimMadge requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions.

I think there are some changes around the framing of how this works I'd like to make.

docs/source/management/index.md Outdated Show resolved Hide resolved
docs/source/management/index.md Outdated Show resolved Hide resolved
docs/source/management/index.md Outdated Show resolved Hide resolved
docs/source/management/index.md Outdated Show resolved Hide resolved
docs/source/management/index.md Outdated Show resolved Hide resolved
docs/source/management/index.md Outdated Show resolved Hide resolved
@craddm craddm requested a review from JimMadge November 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimMadge JimMadge Awaiting requested review from JimMadge

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing admin ip address in config does not update network access to storage accounts
2 participants
@craddm @JimMadge