Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CentOS7 compatibility #25

Open
jdratlif opened this issue Jul 13, 2021 · 1 comment
Open

add CentOS7 compatibility #25

jdratlif opened this issue Jul 13, 2021 · 1 comment

Comments

@jdratlif
Copy link
Contributor

CentOS / RHEL 7 use GCC 4.85, which does not support C++14. However, it doesn't look like your code uses anything from C++14, only C++11, which GCC 4.85 does support.

I tested changing setup.py so that extra_compile_args are -std=c++11 instead of -std=c++14 and it appears to work.

@alex-petrenko
Copy link
Owner

I had to bump from 11 to 14 during the development at some point, but it can be the latest version of the code does not use anything C++-14 specific now. Could also be compiler dependent.

I would really appreciate if you submit a PR, then it will go through automated tests and I'll be happy to merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants