Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests #70

Open
3 of 12 tasks
alexieyizhe opened this issue Oct 28, 2019 · 0 comments
Open
3 of 12 tasks

Add more unit tests #70

alexieyizhe opened this issue Oct 28, 2019 · 0 comments
Labels
effort: high ✨ enhancement New feature or request

Comments

@alexieyizhe
Copy link
Owner

alexieyizhe commented Oct 28, 2019 •
edited
Loading

Use Cypress and https://github.com/bahmutov/cypress-react-unit-test to run unit tests. However, currently support for styled-components and TypeScript is lacking, so this may need to be postponed.

  • Set up framework to write unit tests
  • Write basic unit test

e2e tests

  • All filter options

Unit Tests

The following functionality should be tested:

Components

PageHeader

  • Opening and closing mobile menu
  • Opening and closing add review modal

PageFooter

  • Footer scroll to top

Hooks

useEasterEgg

  • easter egg activates properly on inputting konami code
  • easter egg does not activate on almost correct input

useScrollTopOnMount

  • scrolling to top triggered on mount

useSearch

  • TBD

useSearchParams

  • can you even test this lmao

useUpdateTracer

  • changing props outputs message with changed prop
  • unchanged props should not output message
@alexieyizhe alexieyizhe added ✨ enhancement New feature or request priority: high Should be worked on first status: pending Needs to be tidied up effort: high labels Oct 28, 2019
@alexieyizhe alexieyizhe removed priority: high Should be worked on first status: pending Needs to be tidied up labels Oct 28, 2019
@alexieyizhe alexieyizhe changed the title Add functionality testing Add unit tests Oct 29, 2019
@alexieyizhe alexieyizhe mentioned this issue Oct 29, 2019
Closed
11 tasks
@alexieyizhe alexieyizhe changed the title Add unit tests Set up unit testing and add tests Nov 1, 2019
@alexieyizhe alexieyizhe added priority: low Not as urgent as other tasks and removed priority: low Not as urgent as other tasks labels Nov 1, 2019
@alexieyizhe alexieyizhe mentioned this issue Nov 7, 2019
Merged
@alexieyizhe alexieyizhe changed the title Set up unit testing and add tests Add more unit tests Nov 7, 2019
@alexieyizhe alexieyizhe added the priority: low Not as urgent as other tasks label Nov 10, 2019
@alexieyizhe alexieyizhe removed the priority: low Not as urgent as other tasks label Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: high ✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexieyizhe