Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement haplotype counts in haplo-stats module #65

Open
alexlancaster opened this issue Jun 5, 2023 · 1 comment
Open

Implement haplotype counts in haplo-stats module #65

alexlancaster opened this issue Jun 5, 2023 · 1 comment
Assignees
Labels
bug Something isn't working, should not be used for new features: use "enhancement" for those

Comments

@alexlancaster
Copy link
Owner

haplo-stats is not reporting haplotype counts (splitting off as a separate issue from #38 )

cc: @sjmack

@alexlancaster alexlancaster added the bug Something isn't working, should not be used for new features: use "enhancement" for those label Jun 5, 2023
@alexlancaster
Copy link
Owner Author

A quick review of the code suggests that the haplotype count generation in haplostats was disabled in the XML output pending a check of the numbers, there's a FIXME:

https://github.com/alexlancaster/pypop/blob/main/src/PyPop/Haplo.py#L1013

To test this, we can uncomment the code and check the results manually against a known set, and include a corresponding unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, should not be used for new features: use "enhancement" for those
Projects
None yet
Development

No branches or pull requests

1 participant