Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data tables #152

Open
ivnsch opened this issue Dec 8, 2021 · 0 comments
Open

Use data tables #152

ivnsch opened this issue Dec 8, 2021 · 0 comments

Comments

@ivnsch
Copy link

ivnsch commented Dec 8, 2021

Just forwarding a recommendation I got to use data tables:

cucumber-rs/cucumber#183 (comment)

Instead

And I build an application transaction with the transient account, the current application, suggested params, operation "create", approval-program "programs/big_app_program.teal.tok", clear-program "programs/big_app_program.teal.tok", global-bytes <global-bytes>, global-ints 0, local-bytes <local-bytes>, local-ints 0, app-args "", foreign-apps "", foreign-assets "", app-accounts "", extra-pages 3

do (or similar)

And I build an application transaction with 
  | operation        | create                            |
  | approval-program | programs/big_app_program.teal.tok |
  | clear-program    | programs/big_app_program.teal.tok |
  | global-bytes     | <global-bytes>                    |
  | global-ints      | 0                                 |
  | local-bytes      | <local-bytes>                     |
  | local-ints       | 0                                 |
  | app-args         |                                   |
  | foreign-apps     |                                   |
  | foreign-assets   |                                   |
  | app-accounts     |                                   |
  | extra-pages      | 3                                 |

It would be easier both read/match the step and access the table data via gherkin::Step.

I imagine that these kind of changes are difficult to do, since they'd break the tests in all the SDKs, but worth maybe for future features.

@ivnsch ivnsch added the new-feature-request Feature request that needs triage label Dec 8, 2021
@algoanne algoanne added tech debt and removed new-feature-request Feature request that needs triage labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants