Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation: Can we refactor indexer integration tests to be deterministic? #237

Open
tzaffi opened this issue Sep 21, 2022 · 0 comments

Comments

@tzaffi
Copy link
Contributor

tzaffi commented Sep 21, 2022

Problem

Formerly a comment found in #192 :

A potential improvement space:

we can make this test determinstic (i.e., removing sleep for indexer) by waiting indexer to be at the same round of algod finishing all the box operations.

Once indexer has a round number at least as large as algod finishing box operations, the changes on boxes can be reflected in indexer side.

This is a useful improvement, and more generally, full determinism in integration tests would lead to easier test creation.

Dependencies

None

Urgency

Low - tests are working fine as they are currently designed.

@tzaffi tzaffi added the new-feature-request Feature request that needs triage label Sep 21, 2022
tzaffi pushed a commit that referenced this issue Sep 21, 2022
@michaeldiamant michaeldiamant added Team Scytale and removed new-feature-request Feature request that needs triage labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants