p2p: Make p2p listen address configurable via config.NetAddress #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
suggested changes
Aug 31, 2023
Codecov Report
@@ Coverage Diff @@
## master #5721 +/- ##
==========================================
+ Coverage 54.31% 55.56% +1.24%
==========================================
Files 474 474
Lines 66416 66432 +16
==========================================
+ Hits 36075 36912 +837
+ Misses 27839 27020 -819
+ Partials 2502 2500 -2
... and 80 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
approved these changes
Sep 1, 2023
Eric-Warehime
approved these changes
Sep 1, 2023
algorandskiy
approved these changes
Sep 1, 2023
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make P2P listenAddress and more importantly the port configurable via
config.NetAddress. This is required for algonet functioning to make sure that the services start using expected ports.Test Plan
Added a new test and existing tests should pass