ParseContainerLogLine when no new line #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyuuttaaoo
approved these changes
Feb 12, 2025
yyuuttaaoo
reviewed
Feb 12, 2025
messixukejia
approved these changes
Feb 12, 2025
quzard
added a commit
that referenced
this pull request
Feb 13, 2025
(cherry picked from commit a2e2282)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the Docker stdout processor to enhance log processing and adds new test cases to verify the functionality. The most important changes include modifying the log processing logic to filter logs based on stream type and adding comprehensive tests for the new functionality.
Enhancements to log processing:
plugins/input/docker/stdout/docker_stdout_processor.go: Updated theProcessmethod to useParseContainerLogLinefor parsing log lines andStreamAllowedfor filtering logs based on their stream type before adding them to the collector.New test cases:
plugins/input/docker/stdout/docker_stdout_processor_test.go: Added theTestStreamAllowedmethod to test the log processing for different stream types (stdoutandstderr) for both Docker and containerd logs. This ensures that only allowed streams are processed and collected.