Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevents potential deadlocks and improves thread safety. #2110

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

quzard
Copy link
Collaborator

@quzard quzard commented Feb 25, 2025

This pull request includes changes to the ConfigFeedbackReceiver class in the core/config/feedbacker/ConfigFeedbackReceiver.cpp file. The main goal of these changes is to improve thread safety by ensuring that the Feedback*ConfigStatus methods do not hold a lock while calling the Feedback*ConfigStatus methods on the feedbackable objects.

Thread safety improvements:

  • core/config/feedbacker/ConfigFeedbackReceiver.cpp: Modified the FeedbackContinuousPipelineConfigStatus, FeedbackInstanceConfigStatus, and FeedbackOnetimePipelineConfigStatus methods to first find and store the feedbackable object under a lock, and then call the corresponding Feedback*ConfigStatus method outside the lock. This prevents potential deadlocks and improves thread safety.

@quzard quzard merged commit 2bff0f0 into alibaba:main Feb 26, 2025
15 checks passed
@henryzhx8 henryzhx8 added the bug Something isn't working label Feb 27, 2025
@henryzhx8 henryzhx8 added this to the v3.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants