Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential import collision: import path should be "github.com/etcd-io/etcd", not "github.com/coreos/etcd" #584

Open
HappyHacker123 opened this issue Oct 6, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@HappyHacker123
Copy link

HappyHacker123 commented Oct 6, 2024

Issue Description

This project alibaba/sentinel-golang depends on github.com/etcd-io/etcd which already opted into module and redirects(or rename) its import path from "github.com/coreos/etcd" to "github.com/etcd-io/etcd" . You import github.com/etcd-io/etcd through the old path "github.com/coreos/etcd" . But when downstream module users try to get github.com/etcd-io/etcd through the indirect path "github.com/coreos/etcd" from alibaba/sentinel-golang, they will easily get build errors:
> go get: github.com/coreos/etcd : parsing go.mod:
> module declares its path as: github.com/etcd-io/etcd
> but was required as: github.com/coreos/etcd

Describe what feature you want

Replace all the old import paths, replace "github.com/coreos/etcd" with "github.com/etcd-io/etcd.

@binbin0325
Copy link
Collaborator

Can you submit a pr to fix it

@binbin0325 binbin0325 added the good first issue Good for newcomers label Oct 8, 2024
@578223592
Copy link

Issue Description

This project alibaba/sentinel-golang depends on github.com/etcd-io/etcd which already opted into module and redirects(or rename) its import path from _ "github.com/coreos/etcd" _ to _ "github.com/etcd-io/etcd" _. You import github.com/etcd-io/etcd through the old path _ "github.com/coreos/etcd" . But when downstream module users try to get github.com/etcd-io/etcd through the indirect path _ "github.com/coreos/etcd" from alibaba/sentinel-golang, they will easily get build errors:

go get: github.com/coreos/etcd : parsing go.mod:
module declares its path as: github.com/etcd-io/etcd
but was required as: github.com/coreos/etcd

Describe what feature you want

Replace all the old import paths, replace "github.com/coreos/etcd" with "github.com/etcd-io/etcd.

@binbin0325 @HappyHacker123 maybe it is better to wait the pr:#582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants