Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pypopsift crashes. Investigate. #164

Open
griwodz opened this issue Aug 13, 2024 · 2 comments
Open

Pypopsift crashes. Investigate. #164

griwodz opened this issue Aug 13, 2024 · 2 comments

Comments

@griwodz
Copy link
Member

griwodz commented Aug 13, 2024

Excerpt from a comment by @hhackbarth in #160:

When I try to use it with the pypopsift wrapper from https://github.com/OpenDroneMap/pypopsift and an adapted CMakelists.txt file, also pypopsift builds successfully and can be installed (building wheels) using pip install . in the pypopsift folder. But when I run their example, I still get Segmentation fault (core dumped).

In the CMakelists.txt file I adapted the FetchContent_declare() part to:

FetchContent_Declare(
  popsift
  GIT_REPOSITORY https://github.com/alicevision/popsift/
  GIT_TAG        dev/cmake-native-cuda-jetson
)

This may be an issue related to pypopsift, but as they are only a wrapper, perhaps the popsift API somehow changed meanwhile and you already have an idea, how to fix that or tell me, what I am doing wrong?

Originally posted by @hhackbarth in #160 (comment)

@hhackbarth
Copy link

Thanks.
By the way: PyPopSift also crashed before PR #163, so there is no problem with that PR itself. And I can only speak for Jetson Orin NX (architecture 87).

@griwodz griwodz changed the title Pypopsift crashes after PR #163. Investigate. Pypopsift crashes. Investigate. Aug 15, 2024
@griwodz
Copy link
Member Author

griwodz commented Aug 15, 2024

Oh, so it's a more basic problem.
I'm not sure if I'll have the time to learn enough about Python-C++-binding to search for such a bug.

Maybe the problem is void FeaturesHost::pin( ) in src/popsift/features.cu
I don't remember if cudaHostRegister is simply doing nothing for GPUs where cudaDeviceProp::integrated==true like the Tegra, or if it actually crashes.
If that's the origin of the problem, I could try to fix it as a follow-up to PR #157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants