Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use torch.searchsorted() #8

Open
krihabu opened this issue Jul 6, 2020 · 3 comments
Open

Use torch.searchsorted() #8

krihabu opened this issue Jul 6, 2020 · 3 comments

Comments

@krihabu
Copy link

krihabu commented Jul 6, 2020

Hi!
The new version of PyTorch contains a searchsorted function:
https://pytorch.org/docs/master/generated/torch.searchsorted.html

Are there any plans to integrate it in your code and loose the dependency of your own torchsearchsorted module?

@aliutkus
Copy link
Owner

aliutkus commented Jul 6, 2020

hi
yes indeed, at last!
I'll be glad to abandon the dependency on my searchsorted to switch to pytorch
no time noW though, feel free to PR this, it should be a minor change

@krihabu
Copy link
Author

krihabu commented Jul 7, 2020

I already changed it locally, so that should be no problem.
It's not yet in the latest stable release though, do you want to wait for that?

@xeTaiz
Copy link
Contributor

xeTaiz commented Aug 5, 2020

Since torch.searchsorted is now in the stable release, I made PR #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants