Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 더미 Basket은 조회되지 않도록 수정 #49

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

3Juhwan
Copy link
Member

@3Juhwan 3Juhwan commented Feb 7, 2025

작업 내용

close: #48

  • Basket 도메인 내에 더미 데이터를 구분하는 메서드(isNotEmpty, isEmpty)를 만들었어요.
  • basketRepository에서 subjectId로 검색할 때에 더미 데이터를 제외하는 필터를 추가했어요.
  • API 테스트가 없어서 추가했어요. 새로운 필터 로직에 대한 서비스 테스트도 추가했어요.

@3Juhwan 3Juhwan requested a review from boyekim February 7, 2025 08:09
@3Juhwan 3Juhwan self-assigned this Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Test Results

47 tests   47 ✅  5s ⏱️
15 suites   0 💤
15 files     0 ❌

Results for commit 3b7cdaf.

Copy link
Member

@boyekim boyekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 더 꼼꼼하게 짜주셔서 감사해여🐥🐥

@3Juhwan 3Juhwan merged commit 8fa259f into main Feb 7, 2025
3 checks passed
@3Juhwan 3Juhwan deleted the fix/48-basket-response branch February 7, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

단건 관심 과목을 상세 조회 API의 응답을 수정한다.
2 participants