Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI didn't catch type errors #72

Open
Krakof opened this issue Apr 1, 2024 · 1 comment
Open

CLI didn't catch type errors #72

Krakof opened this issue Apr 1, 2024 · 1 comment

Comments

@Krakof
Copy link

Krakof commented Apr 1, 2024

Hi,
Thanks a lot for the package, it helps us to add strict mode to the project based on lerna monorepo module by module.

Problem:
During react upgrade to v18 we upgraded next packages as well:

    "@testing-library/dom": "9.3.1" -> "9.3.3",
    "@testing-library/jest-dom": "5.16.5" -> "6.2.0",
    "@testing-library/react": "11.2.7" ->  "14.1.2",
    "@testing-library/user-event": "14.4.3" -> "14.5.2"

After that, script "typecheck": "tsc-strict --noEmit --incremental false" runs successfully, despite type errors (IDE still shows errors).
I found out that update of the listed packages to specific versions:

`@testing-library/jest-dom: 6.x.x`
"@testing-library/user-event": 14.5.x

breaks cli check.
We are using package-lock file in project.
Re-generating package-lock breaks cli as well, but there are too much changes to define a problem.

Any thought will be helpful. Thanks in advance

@alanmoo
Copy link

alanmoo commented Jan 6, 2025

I'm experiencing something similar; I wonder if tsc-strict is only checking for errors that violate strictness, but somehow not checking for other typescript errors. The workaround here is to (admittedly as the docs indicate) run typechecks using tsc && tsc-strict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants