sbt-release shouldn't push commits to origin repo

[schmmd]

When we release to Sonatype, the artifacts are not fully released until the artifacts are closed and released (a cancelable process requiring manual intervention). Because of this, I don't think we should push commits to the origin repository automatically.

[dirkgr]

There is something else we could do. We can make the process automatic. There is an sbt plugin that does this, but it does not work right. It might be better to write our own, or clone the one that exists and fix it. The Sonatype web API doesn’t seem very difficult.

On 2015-01-15, at 08:17, Michael Schmitz [email protected] wrote:

Assigned #122 #122 to @dirkgr https://github.com/dirkgr.

—
Reply to this email directly or view it on GitHub #122 (comment).

[schmmd]

What do you want to make automatic? Closing and releasing the repositories? That seems dangerous. Those steps exist manually so you can verify your build before publishing it permanently.

[dirkgr]

That's true, but we don't actually verify anything, do we? Sonatype does a bunch of verification steps, and we just wait until it's done with those before we press the button.

As it is, it's more like a 24h waiting period to buy a gun, i.e., it gives you time to reconsider.

[schmmd]

I generally verify my build artifacts by adding the staging repository and
running a library that depends on them.

On Tue, Jan 20, 2015 at 9:00 AM, Dirk Groeneveld [email protected]
wrote:

That's true, but we don't actually verify anything, do we? Sonatype does a
bunch of verification steps, and we just wait until it's done with those
before we press the button.

As it is, it's more like a 24h waiting period to buy a gun, i.e., it gives
you time to reconsider.

—
Reply to this email directly or view it on GitHub
#122 (comment).

[dirkgr]

That's a lot of diligence. Making me feel like I'm just flying by the seat of my pants :-)

Will change it.

[schmmd]

It actually asks whether you want to push or not, so I'm not sure it requires changing. I submitted this bug when I didn't have my branch set up to track, so it failed.

[dirkgr]

Oh, right. Then I’ll just change the instructions.

On 2015-01-20, at 09:47, Michael Schmitz [email protected] wrote:

It actually asks whether you want to push or not, so I'm not sure it requires changing. I submitted this bug when I didn't have my branch set up to track, so it failed.

—
Reply to this email directly or view it on GitHub #122 (comment).