Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

addLoggingDependencies doesn't work this way #127

Open
dirkgr opened this issue Jan 27, 2015 · 1 comment
Open

addLoggingDependencies doesn't work this way #127

dirkgr opened this issue Jan 27, 2015 · 1 comment

Comments

@dirkgr
Copy link
Member

dirkgr commented Jan 27, 2015

addLoggingDependencies() is supposed to strip logging implementations from dependencies, and replace them with slf4j and logback. Currently, this is called in CoreSettings, which means it is applied first, before any dependencies are added. Those dependencies can then pull in logging implementations we don't want, and nothing will stop them. If we call addLoggingDependencies() again, in build.sbt or somewhere else, we end up with no logging implementations at all.

It might work as expected if instead of removing logback and then adding it again, it just added it and also put a version override in, but that's speculation.

@jkinkead
Copy link
Contributor

The reason for stripping out dependencies is that if you leave them in, which logging library implementation that gets used depends on the class load order.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants