You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.
addLoggingDependencies() is supposed to strip logging implementations from dependencies, and replace them with slf4j and logback. Currently, this is called in CoreSettings, which means it is applied first, before any dependencies are added. Those dependencies can then pull in logging implementations we don't want, and nothing will stop them. If we call addLoggingDependencies() again, in build.sbt or somewhere else, we end up with no logging implementations at all.
It might work as expected if instead of removing logback and then adding it again, it just added it and also put a version override in, but that's speculation.
The text was updated successfully, but these errors were encountered:
The reason for stripping out dependencies is that if you leave them in, which logging library implementation that gets used depends on the class load order.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
addLoggingDependencies()
is supposed to strip logging implementations from dependencies, and replace them withslf4j
andlogback
. Currently, this is called inCoreSettings
, which means it is applied first, before any dependencies are added. Those dependencies can then pull in logging implementations we don't want, and nothing will stop them. If we calladdLoggingDependencies()
again, inbuild.sbt
or somewhere else, we end up with no logging implementations at all.It might work as expected if instead of removing logback and then adding it again, it just added it and also put a version override in, but that's speculation.
The text was updated successfully, but these errors were encountered: