Adding a Rector configuration #426
Open
+70
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Rector configuration and resolves #330.
Rector is a very powerful tool to upgrade code and also ensure consistent code. We use it on Mantle to quickly add types to the code base as well as deal with the Deprecate implicitly nullable parameter types change in PHP 8.4. We also just used it on NYP to upgrade to PHPUnit 11 from 9 without any self-written code.
Future plans: it may be wise to use https://github.com/fsylum/rector-wordpress to keep our plugins automatically up-to-date. Think of https://github.com/fsylum/rector-wordpress/tree/main/config/sets as very easy ways to upgrade a project to a new WordPress version.