-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implement deserde manually for CallFrame #1986
Comments
can i work on this? |
🤚 |
Adding context Reproduce Example from #1156 Code let block_number = 15413811;
let geth_trace_options = GethDebugTracingOptions::default().with_tracer(
GethDebugTracerType::BuiltInTracer(GethDebugBuiltInTracerType::CallTracer),
);
let geth_trace_results = provider
.debug_trace_block_by_number(block_number.into(), geth_trace_options)
.await?;
println!("{}", geth_trace_results.len()); Result
|
@siosw do you still want to take this? |
@mattsse still happy to take a stab at this but will only get around to it early next week |
@mattsse sorry but i need to drop this, more effort than I thought initially and won't have enough capacity. |
Hey @nadtech-hub would you like to take this? |
Absolutely, I'll do it after shipping PRs for current assignments |
Component
rpc
Describe the feature you would like
due to this recursive structure:
alloy/crates/rpc-types-trace/src/geth/call.rs
Lines 34 to 36 in dc3a7fe
the CallFrame end encountered a serde deseerde issue ref #1156
alloy/crates/rpc-types-trace/src/geth/call.rs
Lines 10 to 11 in dc3a7fe
we should manually implement this iteratively and not use recursion via delegated deserialazion calls
Additional context
No response
The text was updated successfully, but these errors were encountered: