Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Improve eip1559 estimation api #2021

Open
mattsse opened this issue Feb 7, 2025 · 1 comment · May be fixed by #2022
Open

[Feature] Improve eip1559 estimation api #2021

mattsse opened this issue Feb 7, 2025 · 1 comment · May be fixed by #2022
Labels
c-provider enhancement New feature or request
Milestone
v1.0

Comments

@mattsse
Copy link
Member

mattsse commented Feb 7, 2025

Component

rpc, provider, pubsub

Describe the feature you would like

this is suboptimal

alloy/crates/provider/src/provider/trait.rs

Line 219 in fb2f997

estimator: Option<EstimatorFunction>,

this should be two functions, one that uses the default estimator and one that uses the default

Additional context

No response
@mattsse mattsse added the enhancement New feature or request label Feb 7, 2025
@mattsse mattsse linked a pull request Feb 7, 2025 that will close this issue
Open
@nadtech-hub
Copy link
Contributor

🤚

@yash-atreya yash-atreya added this to the v1.0 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-provider enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

feat!: add eip1559 estimator type alloy-rs/alloy
3 participants
@mattsse @nadtech-hub @yash-atreya