Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Declare ExecutionPayload trait #2090

Closed
emhane opened this issue Feb 20, 2025 · 2 comments
Closed

[Feature] Declare ExecutionPayload trait #2090

emhane opened this issue Feb 20, 2025 · 2 comments
Labels
blocked This cannot move forward until something else changes enhancement New feature or request

Comments

@emhane
Copy link
Contributor

emhane commented Feb 20, 2025

Component

rpc

Describe the feature you would like

Move trait from reth into alloy-rpc-types-engine
https://github.com/paradigmxyz/reth/blob/2a8f5b883b3db2b2ad567ced10bfc3bb4563fea0/crates/engine/primitives/src/lib.rs#L43-L55

Additional context

No response
@emhane emhane added the enhancement New feature or request label Feb 20, 2025
@mattsse
Copy link
Member

mattsse commented Feb 20, 2025

I think we can hold off on this until we've stabilized this in reth

@mattsse mattsse added the blocked This cannot move forward until something else changes label Feb 20, 2025
@mattsse
Copy link
Member

mattsse commented Feb 28, 2025

I think we can keep this reth specific, because this is only used to unify most of the engine API impl there

@mattsse mattsse closed this as completed Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This cannot move forward until something else changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @emhane