From 335445f3ea8f95e19005bd432d017dbb268eae59 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 22 Apr 2024 20:48:00 +0000 Subject: [PATCH 1/2] build(deps): bump govuk_publishing_components from 37.9.1 to 38.1.0 Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 37.9.1 to 38.1.0. - [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md) - [Commits](https://github.com/alphagov/govuk_publishing_components/compare/v37.9.1...v38.1.0) --- updated-dependencies: - dependency-name: govuk_publishing_components dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 5a6776945..0328421e9 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -188,7 +188,7 @@ GEM govuk_personalisation (0.16.0) plek (>= 1.9.0) rails (>= 6, < 8) - govuk_publishing_components (37.9.1) + govuk_publishing_components (38.1.0) govuk_app_config govuk_personalisation (>= 0.7.0) kramdown @@ -256,7 +256,7 @@ GEM mime-types-data (~> 3.2015) mime-types-data (3.2024.0305) mini_mime (1.1.5) - mini_portile2 (2.8.5) + mini_portile2 (2.8.6) minitest (5.22.3) msgpack (1.7.2) multi_xml (0.6.0) @@ -271,7 +271,7 @@ GEM net-protocol net-protocol (0.2.2) timeout - net-smtp (0.4.0.1) + net-smtp (0.5.0) net-protocol netrc (0.11.0) nio4r (2.7.1) @@ -577,7 +577,7 @@ GEM redis-namespace (1.11.0) redis (>= 4) regexp_parser (2.9.0) - reline (0.5.1) + reline (0.5.2) io-console (~> 0.5) request_store (1.6.0) rack (>= 1.4) @@ -658,9 +658,9 @@ GEM rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) websocket (~> 1.0) - sentry-rails (5.17.2) + sentry-rails (5.17.3) railties (>= 5.0) - sentry-ruby (~> 5.17.2) + sentry-ruby (~> 5.17.3) sentry-ruby (5.17.3) bigdecimal concurrent-ruby (~> 1.0, >= 1.0.2) From 9084659ef3cabb2d0355c2e31ff354c4f059d767 Mon Sep 17 00:00:00 2001 From: Mark Taylor <138604938+mtaylorgds@users.noreply.github.com> Date: Thu, 25 Apr 2024 11:40:11 +0100 Subject: [PATCH 2/2] Remove GA tracking expectations Previously, the govspeak component from the govuk_publishing_components gem was adding GA4 tracking. This has now been removed, so update the test that was asserting on the rendered HTML to match this new behaviour. --- spec/helpers/application_helper_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb index e44e03ee6..8fddc53cd 100644 --- a/spec/helpers/application_helper_spec.rb +++ b/spec/helpers/application_helper_spec.rb @@ -53,7 +53,7 @@ describe "#render_markdown" do it "converts markdown to html" do text = "This is some **bold** text with a [link](/a-page)" - expected_html = "\n
\n

This is some bold text with a link

\n\n
" + expected_html = "\n
\n

This is some bold text with a link

\n\n
" expect(render_markdown(text)).to eq(expected_html) end