Cookie banner extends ConfigurableComponent
#4305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
force-pushed
the
use-config-component
branch
from
7457fd6
to
3ad1357
Compare
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
romaricpascal
approved these changes
Nov 14, 2024
| /** | ||
| * Check support of CookieBanner | ||
| */ | ||
| static checkSupport() { | ||
| Component.checkSupport() | ||
| ConfigurableComponent.checkSupport() |
There was a problem hiding this comment.
suggestion I think super should work here to avoid further updates 😁
Suggested change
| ConfigurableComponent.checkSupport() | |
| super.checkSupport() |
Make the cookie banner extends `ConfigurableComponent` which is now exported from the latest version of `govuk-frontend`. Remove redundant code and update references to the config. Use the `defaults` functionality of `ConfigurableComponent` and provide a `schema`.
patrickpatrickpatrick
force-pushed
the
use-config-component
branch
from
3ad1357
to
0ef3cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the cookie banner extends
ConfigurableComponentwhich is now exported from the latest version ofgovuk-frontend. Remove redundant code and update references to the config. Use thedefaultsfunctionality ofConfigurableComponentand provide aschema.Why
Fixes #4275