Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade our apps to rails 7.2 #1444

Open
5 tasks
AgaDufrat opened this issue Sep 12, 2024 · 0 comments
Open
5 tasks

Upgrade our apps to rails 7.2 #1444

AgaDufrat opened this issue Sep 12, 2024 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@AgaDufrat
Copy link
Contributor

AgaDufrat commented Sep 12, 2024

How

https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-7-1-to-rails-7-2

  • Run rails app:update command and review changes
  • Use 7.2 defaults

Tasks

Suggested steps we followed for Rails 7.0 upgrades

  1. Update Rails version
  • Run rails app:update and accept all changes (press a).
  • Run rubocop -A to auto-fix any stylistic differences between the Rails defaults and our linter rules.
  • Review in git and keep/discard changes as appropriate.
  • Try to retain any config values that seem to have been set for a reason, while keeping new values that replace old defaults. Git blame is helpful here – for example to determine if particular lines were set for a reason, or if they haven’t been touched since the codebase was first generated.
  • Run the test suite to make sure it still passes – ignore deprecation notices, we'll fix them in the next step.
  • Commit changes: git commit -am "Run rails app:update"
  1. Fix deprecation notices
  • Run the test suite and look out for deprecation notices shown in the console.
  • Fix all deprecations. Note that some deprecations may come from other GOV.UK gems, which will need to be resolved in a separate piece of work. It's worth taking a note of them, though, as they can be turned into Trello cards.
  • Commit changes: git commit -am "Fix deprecation notices"
@AgaDufrat AgaDufrat added the dependencies Pull requests that update a dependency file label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant