From 51ee7863549e7e2e5b7fe993923b5cc48ee97ccc Mon Sep 17 00:00:00 2001
From: Minno Dang <mndang@thoughtworks.com>
Date: Wed, 27 Mar 2024 18:41:01 +0000
Subject: [PATCH] Fix Part validation behaviour after upgrading Mongo version

The validations for parts weren't being triggered when parent model (edition) is validated. To get around this we added an explicit custom validation method to enforce the association validation.
The issue that was happening was that only the first part validation message was being shown on the front end instead of everything whenever Parts were created in the old way outlined above.
Quick fix of tests where slugs had `_` in them which are not allowed and failing validation quietly...

Co-authored-by: Laura Ghiorghisor <laura.ghiorghisor@digital.cabinet-office.gov.uk>
---
 app/models/travel_advice_edition.rb       |  5 +++
 spec/models/travel_advice_edition_spec.rb | 38 ++++++++++++++++-------
 2 files changed, 32 insertions(+), 11 deletions(-)

diff --git a/app/models/travel_advice_edition.rb b/app/models/travel_advice_edition.rb
index 9e09dc2e9..c98b8f73e 100644
--- a/app/models/travel_advice_edition.rb
+++ b/app/models/travel_advice_edition.rb
@@ -43,6 +43,7 @@ class TravelAdviceEdition
   validates :version_number, presence: true, uniqueness: { scope: :country_slug }
   validate :alert_status_contains_valid_values
   validate :first_version_cant_be_minor_update
+  validate :parts_valid?
   validates_with SafeHtml
   validates_with LinkValidator
 
@@ -249,6 +250,10 @@ def first_version_cant_be_minor_update
     end
   end
 
+  def parts_valid?
+    parts.map(&:valid?).all?
+  end
+
   def validate_scheduled_publication_time
     errors.add(:scheduled_publication_time, "can't be in the past") if scheduled_publication_time && scheduled_publication_time <= Time.zone.now
   end
diff --git a/spec/models/travel_advice_edition_spec.rb b/spec/models/travel_advice_edition_spec.rb
index 562ae771a..9d9380770 100644
--- a/spec/models/travel_advice_edition_spec.rb
+++ b/spec/models/travel_advice_edition_spec.rb
@@ -569,24 +569,40 @@
   end
 
   context "parts" do
-    it "should merge part validation errors with parent document's errors" do
+    it "should merge part validation errors with parent document's errors when parts are created as nested attributes" do
+      edition = build(:travel_advice_edition,
+                      parts: [
+                        { _id: "54c10d4d759b743528000010", order: "1", title: "", slug: "part-1" },
+                        { _id: "54c10d4d759b743528000011", order: "3", title: "Part 3", slug: "" },
+                        { _id: "54c10d4d759b743528000012", order: "2", title: "Part 2", slug: "part-2" },
+                      ])
+
+      expect(edition).not_to be_valid
+
+      expect(edition.errors[:part]).to eq(["1: Title can't be blank and 3: Slug can't be blank and Slug is invalid"])
+    end
+
+    it "should merge part validation errors with parent document's errors when parts are created as built parts" do
       edition = create(:travel_advice_edition)
-      edition.parts = [
-        Part.new(_id: "54c10d4d759b743528000010", order: "1", title: "", slug: "overview"),
-        Part.new(_id: "54c10d4d759b743528000011", order: "2", title: "Prepare for your appointment", slug: ""),
-        Part.new(_id: "54c10d4d759b743528000012", order: "3", title: "Valid", slug: "valid"),
-      ]
+      edition.parts.build(_id: "54c10d4d759b743528000010", order: "1", title: "", slug: "part-1")
+      edition.parts.build(_id: "54c10d4d759b743528000011", order: "3", title: "Part 3", slug: "")
+      edition.parts.build(_id: "54c10d4d759b743528000012", order: "2", title: "Part 2", slug: "part-2")
 
       expect(edition).not_to be_valid
 
-      expect(edition.errors[:part]).to eq(["1: Title can't be blank and 2: Slug can't be blank and Slug is invalid"])
+      expect(edition.errors[:part]).to eq(["1: Title can't be blank and 3: Slug can't be blank and Slug is invalid"])
     end
 
     it "#whole_body returns ordered parts" do
-      edition = create(:travel_advice_edition)
-      edition.parts.build(_id: "54c10d4d759b743528000010", order: "1", title: "Part 1", slug: "part_1")
-      edition.parts.build(_id: "54c10d4d759b743528000011", order: "3", title: "Part 3", slug: "part_3")
-      edition.parts.build(_id: "54c10d4d759b743528000012", order: "2", title: "Part 2", slug: "part_2")
+      edition = create(:travel_advice_edition,
+                       parts: [
+                         { _id: "54c10d4d759b743528000010", order: "1", title: "Part 1", slug: "part-1" },
+                         { _id: "54c10d4d759b743528000011", order: "3", title: "Part 3", slug: "part-3" },
+                         { _id: "54c10d4d759b743528000012", order: "2", title: "Part 2", slug: "part-2" },
+                       ])
+
+      expect(edition).to be_valid
+
       expect(edition.whole_body).to eq("# Part 1\n\n\n\n# Part 2\n\n\n\n# Part 3\n\n")
     end
   end