Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the retrieval of the word usage examples #570

Open
kirlat opened this issue Dec 9, 2020 · 0 comments
Open

Refactor the retrieval of the word usage examples #570

kirlat opened this issue Dec 9, 2020 · 0 comments

Comments

@kirlat
Copy link
Member

kirlat commented Dec 9, 2020

@balmas: I think we should have an issue for further refactoring here. This method is only called if the wordUsageExamplesON setting was set to 'onLexicalQuery'. If it's set instead to 'onDemand', the still-existing LexicalQuery.getWordUsage data method is called instead. As we have discussed previously, I would like for all resource queries to be able to set as 'pre-cache' or 'on-demand' and for that to trigger when they are called, but we should not have two separate methods for calling them depending upon when they are called. This is fine for this PR, but we do need to refactor it.

(see #568 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant