Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better logging #4

Open
cpg opened this issue May 31, 2018 · 4 comments · May be fixed by #24
Open

better logging #4

cpg opened this issue May 31, 2018 · 4 comments · May be fixed by #24
Assignees
@Solamish

Comments

@cpg
Copy link
Member

cpg commented May 31, 2018 •
edited
Loading

at the moment the log at /var/log/amahi-anywhere.log is fairly basic. i think we tried to use a fairly standard "apache-like" logging. some features would make it more useful.

  • what is the origin of the request (e.g. local IP, remote IP, or at a minimum local/remote)
  • no session information should appear on it. some calls still have that and it should be stripped
  • as we work on NAUs, we will probably need to record the user (there are ways to do that in typical logs, but we're not appearing to have a place for that at the moment)
  • we also should log things like denied accesses
@phoon
Copy link
Contributor

phoon commented Mar 14, 2019

Should we split the access log and error log into 2 files? like access.log and error.log.

@csoni111
Copy link
Member

That would be a good idea @iPeven, just like nginx or apache.

@vishwasmittal
Copy link
Contributor

vishwasmittal commented Apr 4, 2019 •
edited
Loading

I think we can use some good logging tools for that. There is one called logrus. It has multiple logging levels and can also store logs in proper JSON format which can be useful for serving the logs to the user on the dashboard.

@vishwasmittal vishwasmittal linked a pull request May 17, 2019 that will close this issue
Open
@Solamish
Copy link
Contributor

Here is my solution #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Solamish Solamish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved logging vishwasmittal/amahi-anywhere-fs
5 participants
@cpg @csoni111 @phoon @vishwasmittal @Solamish