Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Non-Admin User Support #563

Open
wants to merge 28 commits into
base: beta
Choose a base branch
from
Open

Add Non-Admin User Support #563

wants to merge 28 commits into from

Conversation

chirag-jn
Copy link
Member

No description provided.

# Conflicts:
#	src/main/java/org/amahi/anywhere/AmahiModule.java
#	src/main/java/org/amahi/anywhere/activity/AuthenticationActivity.java
#	src/main/java/org/amahi/anywhere/fragment/NavigationFragment.java
#	src/main/java/org/amahi/anywhere/server/client/ServerClient.java
#	src/main/res/layout/layout_authentication.xml
#	src/main/res/values/strings.xml
@chirag-jn
Copy link
Member Author

Issues with auth_token, will be fixed soon.

@chirag-jn chirag-jn self-assigned this Jul 16, 2020
chirag-jn and others added 4 commits July 17, 2020 02:21
# Conflicts:
#	src/main/java/org/amahi/anywhere/activity/IntroductionActivity.java
#	src/main/java/org/amahi/anywhere/activity/SplashActivity.java
#	src/main/java/org/amahi/anywhere/fragment/NavigationFragment.java
@chirag-jn
Copy link
Member Author

Non-Admin User works fine now. User is able to login by just using a PIN which they can set up at http://hda/tab/users/. However, enough user testing is required to check the corner cases,

@Akash-Ramjyothi
Copy link
Member

@chirag-jn I feel it would be better to replace the normal "EditText" on the PIN Access Fragment and replace them with "TextInputLayout - Floating EditText" with counter enabled and locking it to 4 or 6, alternatively to indicate by a change in color if character exceeds.

Comment on lines 29 to 37
<EditText
android:id="@+id/edit_text_pin"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:gravity="center"
android:hint="@string/hint_pin"
android:imeOptions="actionGo"
android:inputType="textPassword"
android:textSize="@dimen/text_large" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the codes I recommend you to convert to the UI element I specified.

@chirag-jn
Copy link
Member Author

That seems to be a good change, though note that the length of the pin can be 3-5

@cpg cpg self-assigned this Jul 20, 2020
@chirag-jn chirag-jn added the NAU label Jul 29, 2020
@chirag-jn chirag-jn added the feat Feature Issues/Improvements label Aug 23, 2020
@chirag-jn
Copy link
Member Author

Corrected issue of navigation bar not visible for non admin user.

@chirag-jn chirag-jn linked an issue Aug 31, 2020 that may be closed by this pull request
@github-actions
Copy link

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

@github-actions
Copy link

github-actions bot commented Mar 4, 2021

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

@chirag-jn chirag-jn added the on hold Hold on there, buddy! label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicting feat Feature Issues/Improvements NAU on hold Hold on there, buddy!
Projects
None yet
4 participants