Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-geo? #2

Open
waywardmonkeys opened this issue Jul 24, 2016 · 6 comments
Open

rust-geo? #2

waywardmonkeys opened this issue Jul 24, 2016 · 6 comments
Assignees
Milestone

Comments

@waywardmonkeys
Copy link

Would it make sense to try using the geometry primitives from https://github.com/georust/rust-geo instead of your own geometry classes?

cc: @frewsxcv

@frewsxcv
Copy link

If there's anything you need in rust-geo to help facilitate this, don't hesitate to ask me here or open an issue.

@ambaxter ambaxter self-assigned this Jul 25, 2016
@ambaxter
Copy link
Owner

It's definitely something I looked into when originally designing spatial. However, I felt having spatial trees limited to 2D data-types might be too limiting for some applications.

I split off the LeafGeometry trait so that users could supply any spatial data-type and the tree would be able to handle it.

My plan is that, by 0.3 (probably another month or so), I'll have an optional impl for geo. Will that work?

@ambaxter ambaxter added this to the 0.3 milestone Jul 25, 2016
@ambaxter
Copy link
Owner

ambaxter commented Oct 10, 2016

@frewsxcv,

I've finally gotten around to adding the rust-geo optional dependency as seen in #5

About the only thing I'm not sure about is the Polygon/MBR intersection overlap area on https://github.com/ambaxter/spatial-rs/pull/5/files#diff-e60982ca5e6c83804371854dc41996aaR736

The way I handled it is pretty naive. Any suggestions?

@frewsxcv
Copy link

I think for that to be cleaned up we'll need Intersects<Bbox<T>> for Polygon: georust/geo#69

@ambaxter
Copy link
Owner

I wrote my comment wrong. What I really need is overlapped area of a bbox and a polygon.

@frewsxcv
Copy link

Opened an issue for an Intersection trait: georust/geo#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants