Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using more featured shard as dependency #1

Open
faustinoaq opened this issue May 18, 2018 · 8 comments
Open

Consider using more featured shard as dependency #1

faustinoaq opened this issue May 18, 2018 · 8 comments
Labels
kind:enhancement New feature or request status:help-wanted Extra attention is needed

Comments

@faustinoaq
Copy link
Contributor

I think we can enhance this library by integrating a more featured shard like https://github.com/vladfaust/i18n.cr by @vladfaust

@amberframework/contributors WDYT?

@faustinoaq faustinoaq added kind:enhancement New feature or request status:help-wanted Extra attention is needed labels May 18, 2018
@vladfaust
Copy link

I currently have very small experience in Amber, but I'm open to help if needed

@faustinoaq
Copy link
Contributor Author

@vladfaust Oh, Thank you!

BTW, Have you tried https://github.com/TechMagister/i18n.cr by @TechMagister ?

(I just saw the comment in your reddit post 😅 )

@vladfaust
Copy link

I haven’t tried the shard you’ve mentioned yet 🙂

@robacarp
Copy link
Member

@faustinoaq what do you think about folding TechMagister's code into Citrine?

@faustinoaq
Copy link
Contributor Author

what do you think about folding TechMagister's code into Citrine?

Well, if @TechMagister has no problem with that, It's ok for me 😅

@TechMagister
Copy link

I have no problem with that ☺️
But what are the benefits of this vs using it as a dependency ?

@robacarp
Copy link
Member

@TechMagister Shorter chain of dependencies, and code we can maintain.

@eliasjpr
Copy link
Contributor

@TechMagister can you merge this PR crimson-knight/i18n.cr#6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:enhancement New feature or request status:help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants