Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On validation error, should log details #32

Open
gusmith opened this issue Jul 10, 2021 · 1 comment
Open

On validation error, should log details #32

gusmith opened this issue Jul 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@gusmith
Copy link
Contributor

gusmith commented Jul 10, 2021

Observed in Kana's use case: when a prediction validation request is not validated (returning a 422), we do not log what the issue was.
We should log the details of the error (either here or in AtmosphereX) to be able to inform users when such error occurs, but it should not include the values from the request, only the keys which created the error (which I think is the default behaviour from the detail message created by the pydantic validation module).

@gusmith gusmith added the enhancement New feature or request label Jul 10, 2021
@gusmith
Copy link
Contributor Author

gusmith commented Jul 14, 2021

We will need to be sure that the customer is not expected us to provide this logs, as they are currently receiving this information.

AtmosphereX seems simpler to be the place logging it, as custom activities may be implemented by client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant