Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Muted Video #8

Open
sredeker opened this issue Jun 26, 2018 · 1 comment
Open

Support Muted Video #8

sredeker opened this issue Jun 26, 2018 · 1 comment
Labels
enhancement good first issue help wanted

Comments

@sredeker
Copy link

Muting a video works after playback has started but initializing the video as muted is not currently working. This is most likely this is because of a type conversion between the boolean true/false that videojs provides in options, and whatever value the S7 SDK expects as a parameter
amclin added a commit that referenced this issue Jul 23, 2019
@amclin
feat(mute): mute videos on load
dc42de7 
Supposed to Fix #8

//TODO Follows Scene7 documented API and data is passed, but audio is present when playing
@amclin
Copy link
Owner

amclin commented Jul 23, 2019

I've wired up the necessary parameters that match Adobe's documentation, but the documentation appears to be wrong as the videos don't play muted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amclin @sredeker